Re: [PATCH 0/2] Use acpi_dev_present()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday, January 19, 2016 01:12:29 PM Darren Hart wrote:
> On Sun, Jan 17, 2016 at 09:49:41PM +0100, Lukas Wunner wrote:
> > Hi Darren,
> > 
> > the acpi_dev_present() API has now landed in Linus' tree.
> > Thus, after Linus' tree gets merged back into yours,
> > it would be possible to use the API in the pdx86 drivers
> > as per the following patches.
> > 
> > I've also pushed these to GitHub in case anyone prefers
> > perusing them in a browser:
> > https://github.com/l1k/linux/commits/acpi_dev_present_pdx86
> > 
> > This is a repost of patches submitted in November, the only
> > change is one line added to the commit messages to reference
> > the commit which introduces the API:
> > http://thread.gmane.org/gmane.linux.alsa.devel/147414/focus=8004
> > http://thread.gmane.org/gmane.linux.alsa.devel/147414/focus=8005
> 
> Who's tree did the API make it in through? That would likely be the best tree to
> pull these 2 patches in from.
> 
> Robert, Lv, Rafael? Would one of you prefer to take these 2 patches using the
> new API?

It was my tree and I can take these patches, but in that case I'd like the
function's name to be changed as discussed elsewhere.

Executive summary is that we have acpi_dev_present() and acpi_device_is_present()
now and they serve different purposes which is kind of confusing.  Moreover,
acpi_dev_present() doesn't check if the device is actually present, so
I would like it to be renamed to acpi_device_found() or similar.

Thanks,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux