On Fri, Jan 08, 2016 at 11:26:44AM +0000, One Thousand Gnomes wrote: > On Fri, 8 Jan 2016 18:32:27 +0800 > Qipeng Zha <qipeng.zha@xxxxxxxxx> wrote: > > > intel_punit_ipc_command() maybe called when in or out > > data pointers are NULL. > > In which case what happens: the command is not issued but there seems to > be no way for the caller to discover this, and nohing is logged. My reading of this is different. A command receives a type and a val. It may or may not also require data in the "in" buffer, and the caller may or may not provide an out buffer. The command is issued in any case. I have merged this to avoid a crash, but we can certainly revisit this if I have missed something. -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
