> -----Original Message----- > From: platform-driver-x86-owner@xxxxxxxxxxxxxxx [mailto:platform-driver- > x86-owner@xxxxxxxxxxxxxxx] On Behalf Of Darren Hart > Sent: Wednesday, December 30, 2015 6:21 AM > To: Chakravarty, Souvik K <souvik.k.chakravarty@xxxxxxxxx> > Cc: platform-driver-x86@xxxxxxxxxxxxxxx; Kasagar, Srinidhi > <srinidhi.kasagar@xxxxxxxxx>; Zha, Qipeng <qipeng.zha@xxxxxxxxx>; > Muralidhar, Rajeev D <rajeev.d.muralidhar@xxxxxxxxx>; Ghorai, Sukumar > <sukumar.ghorai@xxxxxxxxx>; Yu, Ong Hock <ong.hock.yu@xxxxxxxxx>; Li, > Aubrey <aubrey.li@xxxxxxxxx> > Subject: Re: [PATCH v3 1/5] platform:x86: Add Intel Telemetry Core Driver > > On Wed, Dec 23, 2015 at 04:12:30PM +0530, Souvik Kumar Chakravarty wrote: > > Intel PM Telemetry is a software mechanism via which various SoC PM > > and performance related parameters like PM counters, firmware trace > > verbosity, the status of different devices inside the SoC, etc can be > > monitored and analyzed. The different samples that may be monitored > > can be configured at runtime via exported APIs. > > > > This patch adds the telemetry core driver that implements basic > > exported APIs. > > > > Signed-off-by: Souvik Kumar Chakravarty > > <souvik.k.chakravarty@xxxxxxxxx> > > Qipeng, would you please review this series and confirm that you and Souvik > have aligned on this implementation? Yes I have already aligned with Qipeng internally for this telemetry PMC resource addition. > > > > > > --- > > Changes in v3: > > * Clean code using checkpatch.pl from Kernel v4.3-rc4 > > --- > > Changes in v2: > > * Fix issues in code style, indentation & comments > > * Follow kernel-doc sytle comments > > * Changed Banner to include "All Rights Reserved" > > * Change telemetry_plt_config.telem_in_use type to bool > > * Introduce Default empty platform specific callbacks to remove NULL > > checks > > * Use pr_fmt in init > > * Change to MODULE_LICENSE to GPL > > --- > > ... > > > +static inline int telemetry_get_pssevtname(enum telemetry_unit > telem_unit, > > + const char **name, int len) > > +{ > > + struct telemetry_unit_config psscfg; > > + int i = 0; > > It's a minor nit, but i doesn't need to be initialized here or in the function > below as its initial value is set in the for loop. > > > -- > Darren Hart > Intel Open Source Technology Center > -- > To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" > in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo > info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
