Hi Darren, > -----Original Message----- > From: Darren Hart [mailto:dvhart@xxxxxxxxxxxxx] > Sent: Tuesday, January 05, 2016 4:36 AM > To: Andy Shevchenko > Cc: Weng Xuetian; Chen, Yu C; linux-kernel@xxxxxxxxxxxxxxx; platform- > driver-x86@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v3] surface pro 4: Add support for Surface Pro 4 Buttons > > On Sun, Dec 27, 2015 at 10:58:06PM +0200, Andy Shevchenko wrote: > > On Sun, Dec 27, 2015 at 9:21 PM, Weng Xuetian <wengxt@xxxxxxxxx> > wrote: > > > Surface Pro 4 buttons are managed by a device with _HID "MSHW0040" > > > different from Surface Pro 3. > > > > > > This commit adds MSHW0040 to id list to support the Surface Pro 4, > > > and renames the driver to surfacepro_button accordingly. > > > > > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=109871 > > > Signed-off-by: Weng Xuetian <wengxt@xxxxxxxxx> > > > > Darren, this one looks fine for me, still couple of question up to you. > > > > First is do we really want to rename driver? (Renaming variables and > > stuff like I said if fine to me) > > Sorry, replied before seeing this. > > I agree that renaming the file is probably not necessary (this works on v3+ as > I understand it, so the name isn't really a problem, and dropping the 3 > suggests it works on v1 and v2). > > I'd prefer to keep the name changing to a minimum, and add some > information to the Kconfig help and driver comments making it clear that this > supports 3+. > [Yu] I agree, since I don't have a surface pro < 3 tested, there is no need to rename it. thanks, yu -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
