[PATCH] intel-hid: Fix build failure when CONFIG_INTEL_HID_EVENT=m

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Sedat Dilek <sedat.dilek@xxxxxxxxx>

When building with CONFIG_INTEL_HID_EVENT=m on Andy's luto.git#xps13
Git branch I see the following build failure:

ERROR: "sparse_keymap_setup" [drivers/platform/x86/intel-hid.ko] undefined!
ERROR: "sparse_keymap_report_event" [drivers/platform/x86/intel-hid.ko] undefined!

Looks like 'select INPUT_SPARSEKMAP' is missing.

Fixes: cd8d25841a65 ("intel-hid: new hid event driver for hotkeys")
[andy: fixed commit hash above]
CC: Alex Hung <alex.hung@xxxxxxxxxxxxx>
CC: Andy Lutomirski <luto@xxxxxxxxxx>
Signed-off-by: Sedat Dilek <sedat.dilek@xxxxxxxxx>
Signed-off-by: Andy Lutomirski <luto@xxxxxxxxxx>
---

Hi Alex and Darren-

I'm relaying this fix from Sedat with a trivial correction.

drivers/platform/x86/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index d0bfcf8e8b8e..9d7704e51366 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -736,6 +736,7 @@ config INTEL_HID_EVENT
 	tristate "INTEL HID Event"
 	depends on ACPI
 	depends on INPUT
+	select INPUT_SPARSEKMAP
 	help
 	  This driver provides support for the Intel HID Event hotkey interface.
 	  Some laptops require this driver for hotkey support.
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux