On Monday 28 December 2015 00:14:17 Henrique de Moraes Holschuh wrote: > On Thu, 24 Dec 2015, Pali Rohár wrote: > > This patch adds support for controlling keyboard backlight via > > standard linux led class interface (::kbd_backlight). It uses ACPI > > HKEY device with MLCG and MLCS methods. > > > > Signed-off-by: Pali Rohár <pali.rohar@xxxxxxxxx> > > Tested-by: Fabio D'Urso <fabiodurso@xxxxxxxxxx> > > It looks good at a first glance. But at init you might need to take > steps so that the current state is not changed. Did you test this? Tested. Modprobing driver does not change keyboard backlight level. > Also, is it working properly across suspend+resume? When doing resume from suspend or hibernate BIOS turning keyboard backlight automatically off. But driver at any time report correct backlight level from sysfs node. -- Pali Rohár pali.rohar@xxxxxxxxx
Attachment:
signature.asc
Description: This is a digitally signed message part.
