On Tue, 22 Dec 2015, Hans de Goede wrote: > Use the new acpi_video_handles_brightness_key_presses function to check > if we should report brightness key-presses. > > This makes the code both easier to read and makes it properly report > key-presses when acpi-video is not reporting them for reasons other > then the backlight type being vendor. If this new function will return false when acpi video is not reporting keypresses *BUT* still allowing any sort of brightness changes (e.g. through sysfs), I don't think it is safe in thinkpad-acpi's case. So, will it return false in any situation whether acpi-video attached to the backlight class? -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html