Re: Dell Vostro V131 hotkeys revisited

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Thanks for both the testing and the dmi info, attached is a patch
> which applies on top of the other 4 which should automatically do the
> right thing, can you please test this patch with an "empty" kernel
> cmdline, once that bit works I'll post the entire set upstream for
> merging.

The patch works as expected, thanks!

> From 3225a9c43a02682e3cae5c02ca6d38e923256de1 Mon Sep 17 00:00:00 2001
> From: Hans de Goede <hdegoede@xxxxxxxxxx>
> Date: Fri, 18 Dec 2015 11:36:16 +0100
> Subject: [PATCH 5/5] acpi-video: Add quirks for the Dell Vostro V131
> 
> The Dell Vostro V131 has an especially broken acpi-video implementation.
> 
> The backlight control bits work, but when the brightness is changed via
> the acpi-video interface the backlight flickers annoyingly before settling
> at the new brightness, switching to using the native interface fixes the
> flickering so add a quirk for this (the vendor interface has the same
> problem).
> 
> Brightness keypresses reported through the acpi-video-bus are also broken,
> they get reported one event delayed, so if you press the brightness-up
> hotkey on the keyboard nothing happens, then if you press brightness-down,
> the previous brightness-up event gets reported. Since the keypresses are
> also reported via wmi (if active) and via atkbd (when wmi is not active)
> add a quirk to simply filter out the delayed (broken) events.

Just my two cents here: those brightness events sourced from acpi-video
are only delayed after the special WMI-enabling SMI is raised.  So if
you boot the kernel today, those events won't be lagged because the
special WMI-enabling SMI isn't merged yet.  Of course, those events are
still just useless duplicates.  Extending the commit message by
including this detail might spare posterity confusion.  It's just a
thought, though.

-- 
Best regards,
Michał Kępień
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux