On Tue, Dec 08, 2015 at 02:57:18PM +0200, Andy Shevchenko wrote:
> On Mon, 2015-12-07 at 15:45 -0800, Darren Hart wrote:
> > On Tue, Dec 08, 2015 at 12:55:04AM +0800, Qipeng Zha wrote:
...
>
> > >
> > > res = platform_get_resource(pdev, IORESOURCE_MEM,
> > > - PLAT_RESOURCE_PUNIT_INTER_INDE
> > > X);
> > > + PLAT_RES_PUNIT_BIOS_INTER_INDE
> > > X);
> > > if (!res) {
> > > - dev_err(&pdev->dev, "Failed to get punit inter
> > > resource\n");
> > > + dev_err(&pdev->dev, "Failed to get res of punit
> > > BIOS inter\n");
>
> Darren, can you improve this phrasing, I didn't get what this message
> about?
I wasn't going to mention this unless there was sure to be a v9, it seems that
is likely, so...
Qipeng, in order to ensure the message to the user is clear, it is important not
to use abbreviations (especially non-obvious ones) like "inter" and "res". Note that the user will not necessarily have the sourcecode handy for context.
I believe this message is just attempting to the user that the
platform_get_resource message failed for some reason when attempting to get the
ACPI provided resource for the BIOS interface resource. There are two resources
for each, interface and data.
Without knowing the details of the internals, I would think the following might
be a better message?
dev_err(&pdev->dev, "Failed to get punit BIOS interface platform resource\n");
Similarly for all these messages.
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
