On Thursday 03 December 2015 17:16:06 Darren Hart wrote: > This looks fine to me, and if Pali will ack it, I'll move it from for-review to > testing and Andy will need to update patch 14/14 to accomodate - unless you guys > decide to include this in his. This patch is not enough for enabling 0xe025 key on that Vostro machine. Some extra SMBIOS call is needed, without them ACPI will not send WMI keypress event. Dell SMBIOS call can be done either via WMI or via SMI inb/outb instructions which implements dcdbas.ko driver. Module dell-laptop.ko uses only SMBIOS API for all functionality and uses dcdbas.ko. There is another driver which uses SMBIOS API, but use WMI calls. It is dell-led.ko in leds subsystem. So now I do not know where to put that needed SMBIOS call for enabling 0xe025 hotkey event and also I do not know if it is better to use WMI or dcdbas.ko. Maybe now it could make sense to unify Dell SMBIOS API in kernel and move common functions to one place and let drivers to use just common functions. According to older Dell ACPI WMI documentation in DMI is bit which specify if BIOS support SMBIOS via WMI or not. At least I think this one patch should not be included into kernel until there will be full support for 0xe025 key (adding that SMBIOS call). -- Pali Rohár pali.rohar@xxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
