On Thu, Dec 3, 2015 at 4:07 PM, Darren Hart <dvhart@xxxxxxxxxxxxx> wrote: > On Thu, Dec 03, 2015 at 03:45:11PM -0800, Andy Lutomirski wrote: >> On Thu, Dec 3, 2015 at 3:38 PM, Darren Hart <dvhart@xxxxxxxxxxxxx> wrote: >> > On Mon, Nov 30, 2015 at 05:02:01PM -0800, Andy Lutomirski wrote: >> >> If DMI lists a hotkey that we don't recognize, log and ignore it >> >> instead of trying to map it to keycode 0. I haven't seen this happen, >> >> but it will help maintain the key map in the future and it will help >> >> avoid sending bogus events. >> >> >> >> This also improves the message that we log when we get an unknown key >> >> event. >> >> >> >> Signed-off-by: Andy Lutomirski <luto@xxxxxxxxxx> >> >> --- >> > >> > Please include the individual patch changelogs here under --- in the patch >> > itself - this helps me build confidence that I am indeed looking at the right >> > patch and the expected changes are here. >> >> Will do in the future -- different maintainers have different >> preferences here, I think. > > Oh really? > > This is the documented process in Documentation/SubmittingPatches Section 14) > The canonical patch format... > Ingo and the other -tip maintainers seem to like all the comments up front on the cover letter. Or at least they haven't complained yet. Anyway, I'm giving 'git notes' a try to generate nice change comments for v3. --Andy -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html