On Friday 20 November 2015 17:27:00 Andy Lutomirski wrote: > + if (keycode == KEY_RESERVED) { > + pr_info("firmware scancode %d maps to unrecognized keycode %d\n", > + bios_entry->scancode, bios_entry->keycode); > + continue; > + } Please use "0x%x" instead "%d" for those scan and key codes. Other parts in driver use "0x%x" so that new info message could be more confused if it has decimal codes... With that fix, you can add my: Reviewed-by: Pali Rohár <pali.rohar@xxxxxxxxx> -- Pali Rohár pali.rohar@xxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html