Re: [PATCH 3/3] dell_wmi: Improve unknown hotkey handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 20, 2015 at 4:41 PM, Pali Rohár <pali.rohar@xxxxxxxxx> wrote:
> On Saturday 21 November 2015 01:29:04 Darren Hart wrote:
>> Pali, was this something you wanted to discuss more before I merge
>> it?
>
> Just one note:
>
>> +             if (keycode == 0) {
>
> What about using define KEY_RESERVED instead hardcoded constant 0?
>
>> +                     pr_info("firmware scancode %d maps to unrecognized keycode %d\n", bios_entry->keycode, bios_entry->scancode);
>> +                     continue;
>> +             }
>

That would work, but only because KEY_RESERVED == 0.  Let me send a
better patch.

--Andy
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux