> -----Original Message----- > From: Darren Hart [mailto:dvhart@xxxxxxxxxxxxx] > Sent: Thursday, October 22, 2015 11:05 AM > To: Zha, Qipeng; Rafael Wysocki > Cc: Shevchenko, Andriy; platform-driver-x86@xxxxxxxxxxxxxxx; Westerberg, > Mika > Subject: Re: [PATCH v7] platform:x86: add Intel P-Unit mailbox IPC driver > > On Thu, Oct 22, 2015 at 01:01:32AM +0000, Zha, Qipeng wrote: > > >>Qipeng, can you comment on my understanding of the DSDT and the > driver? > > >> > // Memory32Fixed (ReadWrite, 0x00000000, 0x00001000, BAR1) // > SSRAM > > >> > Memory32Fixed (ReadWrite, 0x00000000, 0x00001000, MDAT) // > PUnit BIOS mailbox Data > > >> size: 0x1000 > > >> And this would be res1 in the driver? > > >> > Memory32Fixed (ReadWrite, 0x00000000, 0x00001000, MINF) // > PUnit BIOS mailbox Interface and GTD/ISPD mailbox > > > > When boot up, BIOS will rewrite the size of these entries, actually the size > for this entry will change to 4B, not the default 0x1000. > > This is real strange implementation for us, as before mentioned, BIOS > implement like this to make it compatible for wos driver. > > > > +Rafael - we're having some trouble mapping the ACPI declared resources > +to the > driver code using them. Qipeng has indicated that the BIOS team is doing > something rather bizarre to meet some requirement from the WOS drivers. > Can you have a look at this thread? I haven't been able to map the ACPI > resources to the driver resources in a way that makes sense to me, and this is > holding up merging the driver. > > Qipeng, this is very strange indeed. How does BIOS change this in a way that > doesn't change the resources ACPI reports to the OS? > > Is the ASL fragment you provided collected from a running Linux system > using acpidump? If so, then the resources ACPI advertises to the OS are not > actually available... and that can't be acceptable. +1. Please confirm that the excerpt has been copied from running Linux OS machine, otherwise please provide the *real* (run-time) excerpt from DSDT using either acpidump or manually copied from /sys/firmware/acpi/tables/DSDT (IIRC). > > Qipeng, I want to get this driver merged, but we have to do the due diligence > to understand how these resources are being used. I've asked several > questions to try and clarify this, but your responses have been very short and > do not fully address the questions. I need your help to fully describe what is > going on with the BARs before I can sign this off and ask Linus to merge it. -- Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> --------------------------------------------------------------------- Intel Finland Oy Registered Address: PL 281, 00181 Helsinki Business Identity Code: 0357606 - 4 Domiciled in Helsinki This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. ��.n��������+%������w��{.n������_���v��z����n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�
