Yes this helps. Seems the checkpatch.pl in 4.3-rc4 has some changes. Will update the patches. BR, Souvik > -----Original Message----- > From: Darren Hart [mailto:dvhart@xxxxxxxxxxxxx] > Sent: Sunday, October 11, 2015 12:08 AM > To: Chakravarty, Souvik K <souvik.k.chakravarty@xxxxxxxxx> > Cc: platform-driver-x86@xxxxxxxxxxxxxxx; Kasagar, Srinidhi > <srinidhi.kasagar@xxxxxxxxx>; Zha, Qipeng <qipeng.zha@xxxxxxxxx> > Subject: Re: [PATCH v2 4/4] platform:x86: Makefile/Kconfig/MAINTAINERS > changes for Intel Telemetry > > On Fri, Oct 09, 2015 at 04:31:40AM +0000, Chakravarty, Souvik K wrote: > > Hi Darren, > > > > I am a bit confused as checkpatch that I pulled from Linus' tree gave me all > clear. > > Can you please send me the log, because I have a clean checkpatch report at > my end. > > > > Sure, using checkpatch.pl from Linux v4.3-rc4: > > $ scripts/checkpatch.pl ~/incoming/*mbox > ------------------------------------------------------------------------------------ > /home/dvhart/incoming/PATCH_v2_1-4_platform- > x86_Add_Intel_Telemetry_Core_Driver.mbox > ------------------------------------------------------------------------------------ > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #51: > new file mode 100644 > > WARNING: Comparisons should place the constant on the right side of the test > #645: FILE: drivers/platform/x86/intel_telemetry_core.c:437: > + if (TELEM_PSS == telem_unit) > > WARNING: Comparisons should place the constant on the right side of the test > #648: FILE: drivers/platform/x86/intel_telemetry_core.c:440: > + else if (TELEM_IOSS == telem_unit) > > total: 0 errors, 3 warnings, 611 lines checked > > /home/dvhart/incoming/PATCH_v2_1-4_platform- > x86_Add_Intel_Telemetry_Core_Driver.mbox has style problems, please > review. > ------------------------------------------------------------------------------------------------- > /home/dvhart/incoming/PATCH_v2_2-4_platform- > x86_Add_Intel_telemetry_platform_device_&_driver.mbox > ------------------------------------------------------------------------------------------------- > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #211: > new file mode 100644 > > WARNING: Block comments use * on subsequent lines > #318: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:103: > +/* The following counters are programmed by default during setup. > + Only 20 allocated to kernel driver */ > > WARNING: Block comments use a trailing */ on a separate line > #318: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:103: > + Only 20 allocated to kernel driver */ > > WARNING: Comparisons should place the constant on the right side of the test > #388: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:173: > + if (TELEM_PSS == telem_unit) > > WARNING: Comparisons should place the constant on the right side of the test > #390: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:175: > + else if (TELEM_IOSS == telem_unit) > > WARNING: Comparisons should place the constant on the right side of the test > #421: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:206: > + if ((len > 0) && (NULL == evtmap)) > > WARNING: Comparisons should place the constant on the right side of the test > #431: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:216: > + if ((len > 0) && (NULL == evtmap)) > > WARNING: Comparisons should place the constant on the right side of the test > #509: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:294: > + if (TELEM_RESET == action) { > > WARNING: Comparisons should place the constant on the right side of the test > #539: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:324: > + if (TELEM_UPDATE == action) { > > WARNING: Comparisons should place the constant on the right side of the test > #571: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:356: > + if (TELEM_ADD == action) { > > WARNING: Comparisons should place the constant on the right side of the test > #642: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:427: > + if (TELEM_RESET == action) { > > WARNING: Comparisons should place the constant on the right side of the test > #669: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:454: > + if (TELEM_UPDATE == action) { > > WARNING: Comparisons should place the constant on the right side of the test > #699: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:484: > + if (TELEM_ADD == action) { > > WARNING: Comparisons should place the constant on the right side of the test > #1204: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:989: > + if (NULL == verbosity) > > total: 0 errors, 14 warnings, 1371 lines checked > > /home/dvhart/incoming/PATCH_v2_2-4_platform- > x86_Add_Intel_telemetry_platform_device_&_driver.mbox has style > problems, please review. > ------------------------------------------------------------------------------------------- > /home/dvhart/incoming/PATCH_v2_3-4_platform- > x86_Add_Intel_Telemetry_Debugfs_interfaces.mbox > ------------------------------------------------------------------------------------------- > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #46: > new file mode 100644 > > total: 0 errors, 1 warnings, 1094 lines checked > > /home/dvhart/incoming/PATCH_v2_3-4_platform- > x86_Add_Intel_Telemetry_Debugfs_interfaces.mbox has style problems, please > review. > ------------------------------------------------------------------------------------------------------------- > /home/dvhart/incoming/PATCH_v2_4-4_platform-x86_Makefile-Kconfig- > MAINTAINERS_changes_for_Intel_Telemetry.mbox > ------------------------------------------------------------------------------------------------------------- > total: 0 errors, 0 warnings, 36 lines checked > > /home/dvhart/incoming/PATCH_v2_4-4_platform-x86_Makefile-Kconfig- > MAINTAINERS_changes_for_Intel_Telemetry.mbox has no obvious style > problems and is ready for submission. > > NOTE: If any of the errors are false positives, please report > them to the maintainer, see CHECKPATCH in MAINTAINERS. > > -- > Darren Hart > Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
