On Fri, Oct 09, 2015 at 06:21:37PM +0300, Andy Shevchenko wrote: > On Fri, 2015-10-09 at 17:11 +0300, Andy Shevchenko wrote: > > No need to use global variable for a mutex. Move it to be a member of > > SCU IPC > > device structure. > > This one is wrong, sorry. > > > > > While here, protect dev member assignment in ->remove() since user > > may > > potentially call unbind from sysfs even if driver is built-in. > > This part is still right. OK. With my minor comment to 1/5 and this change, care to send a v2? -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
