On Fri, Sep 18, 2015 at 10:14:45AM +0530, Souvik Kumar Chakravarty wrote: > Intel PM Telemetry is a software mechanism via which various SoC > PM and performance related parameters like PM counters, firmware > trace verbosity, the status of different devices inside the SoC, etc > can be monitored and analyzed. The different samples that may be > monitored can be configured at runtime via exported APIs. > > This patch adds the telemetry core driver that implements basic > exported APIs. > > Signed-off-by: Souvik Kumar Chakravarty <souvik.k.chakravarty@xxxxxxxxx> Hi Souvik, Each of these trigger some valid issues (mostly coding style) using checkpatch.pl. Please run checkpatch.pl before sending patches so we don't have to spend time on things like comparison ordering, block comment formatting, etc. In my subsequent review, I will not be commenting on things caught be checkpatch.pl, please run it and incorporate those fixes in your next revision. Another note, official Intel guidance is to include "All rights reserved." following the Intel copyright, typically on the following line. You'll find numerous examples within the kernel. -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
