On Fri, Sep 18, 2015 at 01:29:11AM +0000, Zha, Qipeng wrote: > >> >> +/* Some modules are dependent on this, so init earlier */ > >> >> +fs_initcall(intel_punit_ipc_init); > >> > >> >So, what exactly requires this? > >> Those drivers which need to use this Punit APIs in its Probe when do module init. > > >As you know, cross driver calls is something we work to avoid specifically for the issues of load order, etc. As this is a new driver, there shouldn't be in users of this currently. Is it expected there will be in the near future? > > No users currently, Telemetry driver will use Punit APIs. > So you suggest don't support Punit calls for other modules in init stage ? I just saw the Telemetry driver today hit the list, so we have a user. No objection. That patch series had some issues, so I'm waiting for a v2 which I can apply and review properly. Both of these are 4.4 candidates and I'd like them in next for as long as possible, so please watch for Andriy's upcoming review. Thanks for sticking with it. -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
