From: Taku Izumi <izumi.taku@xxxxxxxxxxxxxx> Date: Thu, 20 Aug 2015 17:46:05 +0900 > +obj-$(CONFIG_FUJITSU_ES) += fjes.o > + > +fjes-objs := fjes_main.o > + Please do not have trailing empty lines in any files you add or edit, 'git' warns about this even when applying patches. > +static int fjes_acpi_add(struct acpi_device *device) > +{ > + acpi_status status; > + struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL}; > + union acpi_object *str; > + char str_buf[sizeof(FJES_ACPI_SYMBOL) + 1]; > + int result; > + struct platform_device *plat_dev; Please order your local variables in "reverse christmas tree" order, which means longer lines come before shorter ones. Please correct this problem in your entire submission, as I am not going to point out each and every other place where this problem exists. -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html