On Thu, Aug 06, 2015 at 11:55:29AM -0700, Joe Perches wrote: > On Wed, 2015-08-05 at 16:47 -0700, Darren Hart wrote: > > On Thu, Aug 06, 2015 at 11:20:44AM +0000, Chen, Yu C wrote: > [] > > > Is it ok to keep these codes and add comments like: > > It's your code Yu, do whatever you think appropriate. > > > > /* > > > * When a button(power button/volume button/home button) is > > > * pressed down or released, different ACPI notification codes > > > * will be generated. We can distinguish different event code > > > * and value of buttons by these notification codes, then pass > > > * (EV_KEY, event code(key_code), value(pressed)) to input layer. > > > */ > > > > The commentary is useful regardless. However, I suspect Joe was > > referring to the approach pairing the PRESS and RELEASE cases? > > > > True. > > btw Darren, your computer's email time setting seems off. Nothing gets past kernel devs! Corporate firewall broke ntp for Linux VM from where I sent this, didn't notice until too late. -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
