Re: [PATCH 28/32] sony-laptop: Port to new backlight interface selection API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 10-06-15 23:30, Mattia Dongili wrote:
On Wed, Jun 10, 2015 at 03:01:28PM +0200, Hans de Goede wrote:
Port the backlight selection logic to the new backlight interface
selection API.

This commit also removes various obsolete pr_xxx messages related to
backlight interface selection. These are obsolete because they assume
there is only a vendor or acpi backlight driver and no other choice.
Also they are not necessary, if the user wants to know which backlight
interfaces are registered a simple "ls /sys/class/backlight" suffices.

Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>

Acked-by: Mattia Dongili <malattia@xxxxxxxx>

---
  drivers/platform/x86/sony-laptop.c | 6 ++----
  1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
index e51c1e7..6207be6 100644
--- a/drivers/platform/x86/sony-laptop.c
+++ b/drivers/platform/x86/sony-laptop.c
@@ -69,6 +69,7 @@
  #include <linux/miscdevice.h>
  #endif
  #include <asm/uaccess.h>
+#include <acpi/video.h>

  #define dprintk(fmt, ...)			\
  do {						\
@@ -3199,11 +3200,8 @@ static int sony_nc_add(struct acpi_device *device)
  	}

  	/* setup input devices and helper fifo */
-	if (acpi_video_backlight_support()) {

The comment above is really misplaced. I wouldn'd mind if you got rid of
that too.

I've removed it and squashed the removal of it into this patch. I plan to do
a v2 of this patch-set later today, that will have this change.

Regards,

Hans
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux