On Thursday 21 May 2015 22:53:37 Valdis Kletnieks wrote: > commit 61104aa44529d59bd01a5d51df571ca2823a04b3 > Author: Pali Rohár <pali.rohar@xxxxxxxxx> > Date: Thu May 14 12:54:27 2015 +0200 > > dell-laptop: Use dell-rbtn instead i8042 filter when possible > > causes build errors: > > LD init/built-in.o > drivers/built-in.o: In function `dell_init': > /usr/src/linux-next/drivers/platform/x86/dell-laptop.c:762: undefined > reference to `dell_rbtn_notifier_register' > /usr/src/linux-next/drivers/platform/x86/dell-laptop.c:2016: > undefined reference to `dell_rbtn_notifier_unregister' > drivers/built-in.o: In function `dell_exit': > /usr/src/linux-next/drivers/platform/x86/dell-laptop.c:2041: > undefined reference to `dell_rbtn_notifier_unregister' > > when built with: > > CONFIG_DELL_LAPTOP=y > CONFIG_DELL_RBTN=m > > because the builtin then references a symbol that's in a module. > > Probably needs some Kconfig magic to ensure this case doesn't happen. Darren, what do you prefer as fix? Some Kconfig magic (maybe depends?)? or other magic in dell_rbtn.h to inline empty functions? -- Pali Rohár pali.rohar@xxxxxxxxx
Attachment:
signature.asc
Description: This is a digitally signed message part.
