On Tue, May 19, 2015, at 14:45, Bjørn Mork wrote:
> The conversion to DEVICE_ATTR_* macros failed to fixup a few cases where
> the old attribute names didn't match the show/store function names.
> Instead of renaming the functions, the attributes were renamed. This
> caused an unintentional API change. The hwmon required 'name' attribute
> were among the renamed attribute, causing libsensors to fail to detect
> the hwmon device at all.
>
> Fix by using the DEVICE_ATTR macro for these attributes, allowing the
> show/store functions to keep their system specific prefixes.
>
> Fixes: b4dd04ac6ef8 ("thinkpad_acpi: use DEVICE_ATTR_* macros")
> Cc: Bastien Nocera <hadess@xxxxxxxxxx>
> Cc: Henrique de Moraes Holschuh <hmh@xxxxxxxxxx>
> Signed-off-by: Bjørn Mork <bjorn@xxxxxxx>
> ---
> v2: kept the original function names, using the DEVICE_ATTR instead
Acked-by: Henrique de Moraes Holschuh <hmh@xxxxxxxxxx>
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
