On Wed, May 13, 2015 at 01:48:41PM +0200, Pali Rohár wrote: > Darren, can you review/comment this v2 series? It is OK for 4.2 now? > I thought I was waiting on an Ack from Alex but reviewing the various threads I think he's OK with this. Running the patches through checkpatch reports various issues about tabs (resolved by using proper multi-line comment formatting), line length, and not wrapping strings. I corrected these locally to move things along, but when building: CC [M] drivers/platform/x86/dell-rbtn.o drivers/platform/x86/dell-rbtn.c: In function ‘dell_rbtn_notifier_register’: drivers/platform/x86/dell-rbtn.c:273:2: warning: ignoring return value of ‘driver_for_each_device’, declared with attribute warn_unused_result [-Wunused-result] driver_for_each_device(&rbtn_driver.drv, NULL, &ret, rbtn_inc_count); ^ drivers/platform/x86/dell-rbtn.c:284:3: warning: ignoring return value of ‘driver_for_each_device’, declared with attribute warn_unused_result [-Wunused-result] driver_for_each_device(&rbtn_driver.drv, NULL, (void *)false, ^ drivers/platform/x86/dell-rbtn.c: In function ‘dell_rbtn_notifier_unregister’: drivers/platform/x86/dell-rbtn.c:300:3: warning: ignoring return value of ‘driver_for_each_device’, declared with attribute warn_unused_result [-Wunused-result] driver_for_each_device(&rbtn_driver.drv, NULL, (void *)true, We can't introduce new warnings to the build. I've pushed my fixes to the series to my dell-rbtn branch, please start from there and resolve the above, and resubmit. We can still make 4.2. But please make use of checkpatch and watch for warnings like the above in your builds tests so we can avoid unecessary churn. Thanks, -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
