Fei Registers access is one of ipc functions and other ipc commands can't be wrapped as register access, So I don't think we can only keep regmap apis. Best wishes Qipeng -----Original Message----- From: Yang, Fei Sent: Thursday, April 23, 2015 12:30 PM To: Zha, Qipeng; platform-driver-x86@xxxxxxxxxxxxxxx; dvhart@xxxxxxxxxxxxx; One Thousand Gnomes Cc: Zheng, Qi; Zhong, Huiquan; Chen, Jason CJ Subject: RE: [PATCH] platform:x86: add Intel Broxton PMC IPC driver Qipeng, I think what Alan suggested is to implement regmap without PMC IPC driver, in other words, combine the regmap and pmc_ipc into one driver. That seems to make a lot of sense to me, we really don't need another set of driver APIs to be exposed when there is already regmap in place. -Fei -----Original Message----- From: Zha, Qipeng Sent: Wednesday, April 22, 2015 6:07 PM To: platform-driver-x86@xxxxxxxxxxxxxxx; dvhart@xxxxxxxxxxxxx; One Thousand Gnomes Cc: Zheng, Qi; Zhong, Huiquan; Chen, Jason CJ; Yang, Fei Subject: RE: [PATCH] platform:x86: add Intel Broxton PMC IPC driver Hi Alan Thanks. The register access ipc command is only used to r/w registers on PMIC which is controlled by PMC, Based on current pmic core driver design and Fei's suggestion, we implement regmap interface to Access such registers based on PMC ipc command. Then pmic device driver(or other driver need to access pmic registers) can use generic regmap_read/_write Directly. Best wishes Qipeng -----Original Message----- From: One Thousand Gnomes [mailto:gnomes@xxxxxxxxxxxxxxxxxxx] Sent: Wednesday, April 22, 2015 6:37 PM To: Zha, Qipeng Cc: "platform-driver-x86@xxxxxxxxxxxxxxx\" <platform-driver-x86@xxxxxxxxxxxxxxx>, " dvhart@xxxxxxxxxxxxx " <dvhart@xxxxxxxxxxxxx>, " Yang; Fei " <fei.yang@xxxxxxxxx>, " Zhong@xxxxxxxxxxxxxxxxxxx; Huiquan " <huiquan.zhong@xxxxxxxxx>, " Chen@xxxxxxxxxxxxxxxxxxx; Jason.CJ " <jason.cj.chen@xxxxxxxxx>, " Zheng@xxxxxxxxxxxxxxxxxxx; Qi " <qi.zheng@xxxxxxxxx>"@lxorguk.ukuu.org.uk Subject: Re: [PATCH] platform:x86: add Intel Broxton PMC IPC driver On Wed, 22 Apr 2015 10:32:44 +0000 "Zha, Qipeng" <qipeng.zha@xxxxxxxxx> wrote: > Hi Alan > > a) Register access is one of ipc commands, and we do provide more generic APIs based on regmap subsystem in other patch, > with that, there will be not necessary to check platform(Broxton) for register access. Ok that is good... but can I ask why you have two layers of IPC commands and then regmap - not just a single file that solely provides the regmap interface ? > b) we separate scu and pmc ipc in two drivers, is because they are many difference in hw itself, it composite several sub devices > in hardware layer, and supported ipc commands are different, I expected user driver will not check platform(Broxston...) to do > ipc with scu or pmc when no common commands. Ok Alan -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
