On Wed, Feb 18, 2015 at 09:53:44PM +0100, Bastien Nocera wrote: Commit message please. > Signed-off-by: Bastien Nocera <hadess@xxxxxxxxxx> > --- > drivers/platform/x86/thinkpad_acpi.c | 71 +++++++++++++++++++++++++++++++----- > 1 file changed, 62 insertions(+), 9 deletions(-) > > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c > index a6dd017..562d958 100644 > --- a/drivers/platform/x86/thinkpad_acpi.c > +++ b/drivers/platform/x86/thinkpad_acpi.c ... > +static struct device_attribute dev_attr_adaptive_kbd_mode = > + __ATTR(adaptive_kbd_mode, S_IWUSR | S_IRUGO, > + adaptive_kbd_mode_show, adaptive_kbd_mode_store); > + Please use DEVICE_ATTR_RW() macros for new sysfs files. I'd very much like to see a cleanup of the driver to use these as well. Henrique, your thoughts / preference? -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
