TCO driver is anyway auto-loaded by mfd driver lpc_ich as a sub-function of it. The aim of my patch is only to add warning interrupt support in TCO driver. For this it need the GPE number which is exposed by Bios in acpi tables. So the patch registers also the TCO driver as an acpi driver to be able to retrieve this value. The acpi code part is only required by the interrupt handling support, not needed for the loading of the driver itself (already done by lpc_ich). In this context I don't see the point of dissociating the driver part from the loading, unless the loading would need to be reverted later. Thanks, François-Nicolas -----Original Message----- From: Guenter Roeck [mailto:linux@xxxxxxxxxxxx] Sent: Wednesday, January 14, 2015 7:17 PM To: Muller, Francois-nicolas Cc: Darren Hart; 'platform-driver-x86@xxxxxxxxxxxxxxx'; Rafael Wysocki; Linux ACPI Mailing List; linux-watchdog@xxxxxxxxxxxxxxx; Wim Van Sebroeck Subject: Re: [PATCH] TCO Watchdog warning interrupt driver creation On Wed, Jan 14, 2015 at 04:32:33PM +0000, Muller, Francois-nicolas wrote: > Thanks for your review, my comments embedded below. > I'm sending the new version of the patch in the following email. > François-Nicolas > ... > >> > >> +static const struct acpi_device_id iTCO_wdt_ids[] = { > >> + {"8086229C", 0}, > >> + {"", 0}, > >> +}; > >> +MODULE_DEVICE_TABLE(acpi, iTCO_wdt_ids); > >> + > > > >Doesn't that result in auto-loading the driver ? > > The driver is loaded only when Bios exposes the acpi device and the boot param warn_irq is true. > Could you clarify ? I don't understand the issue. > Unless I am missing something, you are making two changes in a single patch. - auto-load driver if acpi device is exposed by bios - Add interrupt handling support I suggested to separate those changes into two patches. Guenter -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
