On Tue, Dec 02, 2014 at 10:36:31PM -0700, Azael Avalos wrote: > The hotkey enabling code is being used by > *_setup_keyboard and also by *_resume. > > This patch creates a new function called > toshiba_acpi_enable_hotkeys to be used by > these two functions to avoid duplicating > code. 42 is a little bit narrow, even for us kernel types :-) 72 characters wide is fine. Patch is fine, but since I had some questions on your others, please correct in V2. Thanks, -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html