On Wed, Sep 17, 2014 at 11:47:21PM +0200, Frans Klaver wrote: > Device attributes are instantiated manually, while we have DEVICE_ATTR* > macros available to do much of the work for us. Let's use them. > > Signed-off-by: Frans Klaver <fransklaver@xxxxxxxxx> > --- > drivers/platform/x86/eeepc-laptop.c | 34 ++++------------------------------ > 1 file changed, 4 insertions(+), 30 deletions(-) > > diff --git a/drivers/platform/x86/eeepc-laptop.c b/drivers/platform/x86/eeepc-laptop.c > index 0094449..db26f78 100644 > --- a/drivers/platform/x86/eeepc-laptop.c > +++ b/drivers/platform/x86/eeepc-laptop.c > @@ -308,13 +308,7 @@ static ssize_t show_sys_acpi(struct device *dev, int cm, char *buf) > { \ > return store_sys_acpi(dev, _cm, buf, count); \ > } \ > - static struct device_attribute dev_attr_##_name = { \ > - .attr = { \ > - .name = __stringify(_name), \ > - .mode = _mode }, \ > - .show = _name##_show, \ > - .store = _name##_store, \ > - } > + static DEVICE_ATTR(_name, _mode, _name##_show, _name##_store) Can you change this to be DEVICE_ATTR_RO()? If not, split it up into 2 different macros, one using the _RW and one _RO version, _never_ have the driver specify the mode of the sysfs file please. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html