Here's the first version of a patch series following discussion [1]. The series applies on top of "eeepc-laptop: simplify parse_arg()"[2]. This also includes some cleanups that weren't in the original discussion, but should probably be taken into account. [1] https://lkml.org/lkml/2014/9/3/865 [2] https://lkml.org/lkml/2014/9/10/742 For those interested, a proper branch is available at: https://github.com/fransklaver/linux wip/eeepc_cleanup_v1 Frans Klaver (13): eeepc-laptop: coding style: fix indentation eeepc-laptop: coding style: add curly braces around else compound eeepc-laptop: coding style: add curly braces around else compound eeepc-laptop: use symbolic permissions in device attributes eeepc-laptop: use DEVICE_ATTR to instantiate device_attributes eeepc-laptop: pull out ACPI_STORE_FUNC and ACPI_SHOW_FUNC macros eeepc-laptop: make disp attribute really write-only eeepc-laptop: pull out SENSOR_STORE_FUNC and SENSOR_SHOW_FUNC macros eeepc-laptop: make fan1_input really read-only eeepc-laptop: compare proper return values in get_cpufv eeepc-laptop: propagate errors from get_cpufv eeepc-laptop: store_cpufv: return error if set_acpi fails eeepc-laptop: return -ENXIO if acpi getter or setter fails drivers/platform/x86/eeepc-laptop.c | 118 +++++++++++++++++++----------------- 1 file changed, 62 insertions(+), 56 deletions(-) -- 2.1.0 -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html