Hi there, 2014-09-05 20:42 GMT-06:00 Darren Hart <dvhart@xxxxxxxxxxxxx>: > On Fri, Sep 05, 2014 at 11:14:05AM -0600, Azael Avalos wrote: >> The accelerometer sensor is very sensitive, and having userspace >> poll the sysfs position entry is not very battery friendly. >> >> This patch removes the sysfs entry and instead, it creates an >> input polled device (joystick) for the built-in accelerometer. > > Hrm, while sysfs details can change across kernel versions, usually due to > driver core changes, we try to keep them as consistent as possible so as not to > break userspace. > > That said, if we are going to try and come up with a better model for > representing an accelerometer, wouldn't treating it as an IIO device be the more > logical approach? Yes of course, but the actual accelerometer device (sensor?) is not really exposed, only certain "functions" it provides, and they are divided across two different ACPI devices, TOS620A exposes the protection, and the TOS1900 (and et. al.) only exposes the axes. I see your point in breaking userspace, but given the fact that it was recently introduced, I didn't thought it was already "adopted", that's why I decided to remove the sysfs entry. Then we might as well keep the sysfs entry and have the input polled device as well. > > -- > Darren Hart > Intel Open Source Technology Center Cheers Azael -- -- El mundo apesta y vosotros apestais tambien -- -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
