On Wed, Jun 11, 2014 at 04:13:00PM +0200, Hans de Goede wrote: > That might work, note that part of the problem is the BIOS exporting > an acpi-video interface. So we would either need to do this check > in the acpi-video driver, or alternatively do it in the asus-wmi driver > and call acpi_video_dmi_promote_vendor() when the check fails. Mm. Doing it in asus-wmi sounds like a reasonable plan for the moment if we don't see this more generally. > I'm not 100% sold on adding this check in general, because it assumes > that the chassis type will be reliable, which seems like a long shot, > ie what if an all in one, with a backlight, uses 3 / Desktop as chassis > type ? I'm sure someone will let us know if we break that. > Note that once the acpi-video interface is disabled by using e.g. > acpi_backlight=vendor, then the asus-wmi driver will create a backlight > control with a max_brightness of 0, which seems like a bug in the asus-wmi > driver. I did not do a patch for this because I was afraid that not > registering the asus-wmi brightness control when the max_brightness == 0 > might cause regressions (e.g. it will also remove the bl_power function, > what if in some cases max_brightness == 0, but we want / need bl_power ?) . I'd be... surprised if anyone's using the interface that way. Let's give it a go and see? -- Matthew Garrett | mjg59@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
