Re: [PATCH RESEND] fujitsu-laptop: Drop unneeded include

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Rafael,

Le Wednesday 19 March 2014 à 23:33 +0100, Rafael J. Wysocki a écrit :
> On Wednesday, March 19, 2014 07:38:46 PM Jean Delvare wrote:
> > The fujitsu-laptop driver includes <linux/video_output.h> but doesn't
> > call any of its functions. Drop the unneeded include to avoid
> > unnecessary driver rebuilds.
> > 
> > Signed-off-by: Jean Delvare <jdelvare@xxxxxxx>
> > Acked-by: Jonathan Woithe <jwoithe@xxxxxxxxxx>
> > Cc: Matthew Garrett <matthew.garrett@xxxxxxxxxx>
> 
> Well, thanks, but why didn't you send it to the same CC list as the original
> patch set?  This doesn't make it particularly convenient to handle ...

Sorry, I resent that one in a hurry and did not put enough thoughts into
it, I'm afraid.

That being said, I don't think it is really a big problem. This is a
minor clean up, obviously correct and needed, so nobody is going to
argue against it. If you are the one applying the patch set then the
only important thing is that you have this extra patch available so that
you don't break the build.

If anyone else is really interested, well, I have explained the problem
in the other thread so they are at least aware of it, and they can
always contact me (or you) to get the missing piece. If they really
care, that is, which I somehow doubt.

Thanks,
-- 
Jean Delvare
SUSE L3 Support

--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux