Hi Tobias, Thanks for your comments. Shuduo On 03/04/2014 05:19 PM, Tobias Klauser wrote: > On 2014-03-03 at 17:31:08 +0100, Shuduo Sang <shuduo.sang@xxxxxxxxxxxxx> wrote: > [...] >> +/* press Fn key a while second, it will switch to Function Mode. Then >> + * release Fn key, previous mode be restored. >> + */ >> +bool adaptive_keyboard_mode_is_saved; >> +int adaptive_keybarod_prev_mode; > > These should probably be made static, since they're only used inside the > module. > Yes. Let me fix it in V3. >> +static int adaptive_keyboard_get_next_mode(int mode) >> +{ >> + int i; >> + int max_mode = ARRAY_SIZE(adaptive_keyboard_modes) - 1; > > sizeof and thus ARRAY_SIZE returns a size_t, so i and max_mode could be > of type size_t as well. > Agree. Will fix in V3. >> + >> + for (i = 0; i <= max_mode; i++) { >> + if (adaptive_keyboard_modes[i] == mode) >> + break; >> + } >> + >> + if (i >= max_mode) >> + i = 0; >> + else >> + i++; >> + >> + return adaptive_keyboard_modes[i]; >> +} >> + >> +static bool adaptive_keyboard_hotkey_notify_hotkey(unsigned int scancode) >> +{ >> + u32 current_mode = 0; >> + int new_mode = 0; >> + >> + switch (scancode) { >> + case DFR_CHANGE_ROW: >> + if (adaptive_keyboard_mode_is_saved) { >> + new_mode = adaptive_keybarod_prev_mode; >> + adaptive_keyboard_mode_is_saved = false; >> + } else { >> + if (!acpi_evalf( >> + hkey_handle, ¤t_mode, >> + "GTRW", "dd", 0)) { >> + pr_err("Cannot read adaptive keyboard mode\n"); >> + return false; >> + } else { >> + new_mode = adaptive_keyboard_get_next_mode( >> + current_mode); >> + } >> + } >> + >> + if (!acpi_evalf(hkey_handle, NULL, "STRW", "vd", new_mode)) { >> + pr_err("Cannot set adaptive keyboard mode\n"); >> + return false; >> + } >> + >> + return true; >> + >> + case DFR_SHOW_QUICKVIEW_ROW: >> + if (!acpi_evalf(hkey_handle, >> + &adaptive_keybarod_prev_mode, >> + "GTRW", "dd", 0)) { >> + pr_err("Cannot read adaptive keyboard mode\n"); >> + return false; >> + } else { >> + adaptive_keyboard_mode_is_saved = true; >> + >> + if (!acpi_evalf(hkey_handle, >> + NULL, "STRW", "vd", FUNCTION_MODE)) { >> + pr_err("Cannot set adaptive keyboard mode\n"); >> + return false; >> + } >> + } >> + return true; >> + >> + default: >> + return false; >> + } >> +} >> + >> static bool hotkey_notify_hotkey(const u32 hkey, >> bool *send_acpi_ev, >> bool *ignore_acpi_ev) >> @@ -3456,6 +3556,8 @@ static bool hotkey_notify_hotkey(const u32 hkey, >> *ignore_acpi_ev = true; >> } >> return true; >> + } else { >> + return adaptive_keyboard_hotkey_notify_hotkey(scancode); >> } >> return false; >> } >> -- >> 1.9.0 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ >> -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html