On Tuesday, January 07, 2014 10:48:05 AM David E. Box wrote: > On Tue, Jan 07, 2014 at 10:15:03AM -0800, Randy Dunlap wrote: > > On 01/07/14 10:03, David E. Box wrote: > > > From: "David E. Box" <david.e.box@xxxxxxxxxxxxxxx> > > > > > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > > > index b51a746..6e199a5 100644 > > > --- a/drivers/platform/x86/Kconfig > > > +++ b/drivers/platform/x86/Kconfig > > > @@ -819,4 +819,14 @@ config PVPANIC > > > a paravirtualized device provided by QEMU; it lets a virtual machine > > > (guest) communicate panic events to the host. > > > > > > +config INTEL_BAYTRAIL_MBI > > > + tristate > > > > Is this kconfig option displayed when you run menuconfig/nconfig/xconfig/gconfig etc.? > > Doesn't it need a prompt string? > > How did you enable it and test it? > > > > It is not displayed on purpose. The driver isn't exposed to user space. > It was tested by adding the option to .config, both as module and built-in. > > > > + depends on PCI > > > + ---help--- > > > + Needed on Baytrail platforms for access to the IOSF Sideband Mailbox > > > + Interface. This is a requirement for systems that need to configure > > > + the PUNIT for power management features such as RAPL. Register > > > + addresses and r/w opcodes are defined in > > > > Think of users reading this. At least change "r/w" to read/write. > > What is IOSF? does it matter here? > > PUNIT? RAPL? > > > > If you don't know what the IOSF Sideband is you probably shouldn't be enabling > this feature. What about generic x86 distro kernels? They won't know in advance whether or not they will need this feature. Thanks! -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
