On Mon, Nov 11, 2013 at 02:56:30PM +0100, Julian Andres Klode wrote: > Add support for battery charge thresholds in new Sandy Bridge and Ivy Bridge > ThinkPads. Based on the unofficial documentation in tpacpi-bat. > > The threshold files support the values '0' for the controller's default, > and 1-99 as percentages. Values outside of that range are rejected. The > behaviour of '0' might be confusing, especially for the stop case where > it basically seems to mean '100'. Thinking more about this, it might make more sense to simply accept a 100 value and not accept a 0 value in the stop case (I tried multiple times to write 100 to a stop_charge_thresh file, because that feels more natural). Having a 0 mean 100% is just odd. So stop_charge_thresh should simply accepts integer values in the range [1, 100] (and start_charge_thresh should continue accept [0, 99], as 0 really means 0 there). -- Julian Andres Klode - Debian Developer, Ubuntu Member See http://wiki.debian.org/JulianAndresKlode and http://jak-linux.org/. Please do not top-post if possible. -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
