On Mon, Oct 14, 2013 at 6:34 PM, Matthew Garrett <mjg59@xxxxxxxxxxxxx> wrote: > On Mon, Oct 14, 2013 at 06:27:33PM -0500, Felipe Contreras wrote: >> On Mon, Oct 14, 2013 at 6:22 PM, Matthew Garrett <mjg59@xxxxxxxxxxxxx> wrote: >> > The easiest is to just do it from userspace. I think Intel have some >> > code for doing this, but I haven't looked at the thermal code for years. >> >> That defeats the purpose of the whole thermal binding infrastructure. > > Not really, but I agree it's not ideal. So what's the point of thermal_zone_bind_cooling_device? >> >> > I don't think you can easily register multiple drivers for the same WMI >> >> > device. >> >> >> >> I don't mean this one, I mean the standalone one. Actually, the first >> >> one I sent doesn't require all this system memory stuff. >> > >> > Banging EC registers directly is the wrong thing to do. Going via WMI is >> > correct. >> >> I'm not going to bother arguing against your absolutist rhetoric. The >> fact is one patch can be applied, the other can't. Besides, nobody >> said anything about banging EC registers directly. > > I'm sorry, you're right - you're calling ACPI methods directly instead. > This is still incorrect. The platform provides an exported interface, > and you should use that exported interface. Maybe, but I can call those same methods outside asus-wmi. > As long as Corentin doesn't object, I'm happy to merge this driver in > its current form (including virt_to_phys()) providing that it's wrapped > in CONFIG_STAGING, and assuming that you'll do the supporting work in > acpica. I'll pull it out again in 6 months or so if that hasn't been > fixed up. Fair? That's fair, I'll give that a try soon. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
