This (and the other two along similar lines) look ok to me.
Acked-by: Jonathan Woithe <jwoithe@xxxxxxxxxx>
On Tue, Sep 03, 2013 at 08:31:52AM +0800, Zhang Rui wrote:
> acpi_execute_simple_method() is a new ACPI API introduced to invoke
> an ACPI control method that has single integer parameter and no return value.
>
> Convert acpi_evaluate_object() to acpi_execute_simple_method()
> in drivers/platform/x86/fujitsu-laptop.c
> Signed-off-by: Zhang Rui <rui.zhang@xxxxxxxxx>
> CC: Matthew Garrett <matthew.garrett@xxxxxxxxxx>
> CC: Jonathan Woithe <jwoithe@xxxxxxxxxxxxxxxxxxxxxxx>
> CC: platform-driver-x86@xxxxxxxxxxxxxxx
> ---
> drivers/platform/x86/fujitsu-laptop.c | 11 ++---------
> 1 file changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
> index 52b8a97..29738cb 100644
> --- a/drivers/platform/x86/fujitsu-laptop.c
> +++ b/drivers/platform/x86/fujitsu-laptop.c
> @@ -317,8 +317,6 @@ static enum led_brightness kblamps_get(struct led_classdev *cdev)
> static int set_lcd_level(int level)
> {
> acpi_status status = AE_OK;
> - union acpi_object arg0 = { ACPI_TYPE_INTEGER };
> - struct acpi_object_list arg_list = { 1, &arg0 };
> acpi_handle handle = NULL;
>
> vdbg_printk(FUJLAPTOP_DBG_TRACE, "set lcd level via SBLL [%d]\n",
> @@ -333,9 +331,8 @@ static int set_lcd_level(int level)
> return -ENODEV;
> }
>
> - arg0.integer.value = level;
>
> - status = acpi_evaluate_object(handle, NULL, &arg_list, NULL);
> + status = acpi_execute_simple_method(handle, NULL, level);
> if (ACPI_FAILURE(status))
> return -ENODEV;
>
> @@ -345,8 +342,6 @@ static int set_lcd_level(int level)
> static int set_lcd_level_alt(int level)
> {
> acpi_status status = AE_OK;
> - union acpi_object arg0 = { ACPI_TYPE_INTEGER };
> - struct acpi_object_list arg_list = { 1, &arg0 };
> acpi_handle handle = NULL;
>
> vdbg_printk(FUJLAPTOP_DBG_TRACE, "set lcd level via SBL2 [%d]\n",
> @@ -361,9 +356,7 @@ static int set_lcd_level_alt(int level)
> return -ENODEV;
> }
>
> - arg0.integer.value = level;
> -
> - status = acpi_evaluate_object(handle, NULL, &arg_list, NULL);
> + status = acpi_execute_simple_method(handle, NULL, level);
> if (ACPI_FAILURE(status))
> return -ENODEV;
>
> --
> 1.8.1.2
--
Dr Jonathan Woithe
Research Scientist and System administrator
Atmospheric Radar Systems
email: jwoithe@xxxxxxxxxxxx
website: http://www.physics.adelaide.edu.au/~jwoithe
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
