On Mon, 2013-07-22 at 01:09 +0100, Grant Likely wrote: > On Thu, Jul 4, 2013 at 5:26 PM, Mark Brown <broonie@xxxxxxxxxx> wrote: > > On Thu, Jun 27, 2013 at 10:43:38PM -0700, Darren Hart wrote: > > > >> minnow_hwid() just returns an int that the minnowboard platform driver > >> read from the GPIO. This seems like a proper abstraction to me. Do you > >> object to this one as well? > > > > We should really have a subsystem for this too - the general idea idea > > of identifying boards, fit options and so on by looking at things like > > GPIOs or numbers in flash is really common. > > And yet this is a platform with ACPI. I would expect the ACPI to > identify the board, not a custom driver. The newest ACPI spec adds a > lot of nice useful things like GPIO and SPI bindings. Talk to Al Stone > about the progress his team has made on adding GPIO support to ACPICA. > > This driver shouldn't be merged into mainline. Keep it as an > out-of-tree patch until the proper solution is implemented. That > shouldn't be too onerous since we now have available not one, but two > mechanisms for describing exactly what you want to do; ACPI or FDT. Yes, that is the current plan. I have isolated the necessary patches for bug fixes (merged, serial support (merged) and networking support (under review). I am exploring different options with ACPI for how to best handle the GPIO (LEDs and Keys) and the Lure device descriptions. -- Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html