On 04/13/2013 12:21 PM, Matthew Garrett wrote:
On Sat, 2013-04-13 at 08:36 -0400, Kyle Evans wrote:
Sure, sorry about that. I was hoping the GUID would be enough. I'll see
what I can come up with.
Sure there's no WMI method that makes the EC write? It's a little weird
for WMI drivers to have to hit the EC directly.
I have no idea, I didn't know what a DSDT was before trying to get these
buttons working.
...A quick grep reveals acpi_wmi_ec_space_handler, is that what I should
use? It calls ec_write itself, but has more function parameters and of
course error checking to make sure you don't screw up those extra
parameters. Seems inefficient to me. Or, maybe like it was designed for
an automated code routine.
Looking further, I don't see any other drivers that use it, ec_write
seems to be the standard.
Your call though, you are the master in this domain and you wrote the
driver.
static acpi_status
acpi_wmi_ec_space_handler(u32 function, acpi_physical_address address,
u32 bits, u64 *value,
void *handler_context, void *region_context)
{
int result = 0, i = 0;
u8 temp = 0;
if ((address > 0xFF) || !value)
return AE_BAD_PARAMETER;
if (function != ACPI_READ && function != ACPI_WRITE)
return AE_BAD_PARAMETER;
if (bits != 8)
return AE_BAD_PARAMETER;
if (function == ACPI_READ) {
result = ec_read(address, &temp);
(*value) |= ((u64)temp) << i;
} else {
temp = 0xff & ((*value) >> i);
result = ec_write(address, temp);
}
switch (result) {
case -EINVAL:
return AE_BAD_PARAMETER;
break;
case -ENODEV:
return AE_NOT_FOUND;
break;
case -ETIME:
return AE_TIME;
break;
default:
return AE_OK;
}
}
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
