On Tue, 09 Apr 2013 09:00:37 -0700
Joe Perches <joe@xxxxxxxxxxx> wrote:
> > +static int start_periodic_polling(void)
> > +{
> > + if (polling_started)
> > + goto out;
> > + schedule_delayed_work(&rapl_polling_work, 0);
> > + polling_started = true;
>
> Should polling_started be device specific (in struct rapl_data ?)
> instead of a single instance static?
hmmm, one of the future improvements is to add support for multi
package CPUs. I intend to use rapl_data for per package common data
across different domains but use a single polling thread to reduce
wakeups if we were to poll on multiple packages. So in that sense, I
want to keep the polling_started flag as a single instance within the
driver.
--
Thanks,
Jacob
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
