On Tue, Apr 02, 2013 at 02:47:35PM -0700, Randy Dunlap wrote: > On 04/02/13 15:15, Jacob Pan wrote: > > diff --git a/drivers/platform/x86/intel_rapl.c b/drivers/platform/x86/intel_rapl.c > > new file mode 100644 > > index 0000000..56ee928 > > --- /dev/null > > +++ b/drivers/platform/x86/intel_rapl.c > > @@ -0,0 +1,1323 @@ > > +/* > > + * intel_rapl.c - Intel Running Average Power Limit Driver for MSR based > > + * RAPL interface > > + * > > + * Copyright (c) 2013, Intel Corporation. > > + * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > +#include <linux/sysfs.h> > > + > > > +#include "../../../fs/sysfs/sysfs.h" > > > What does this driver need from ^^^^^^ that file, which says: > > * fs/sysfs/sysfs.h - sysfs internal header file > > and should that be moved to include/linux/sysfs.h ? See my other complain about this already, I beat you to it :) greg k-h -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html