On Fri, Mar 08, 2013 at 03:44:30PM +0800, AceLan Kao wrote:
> static const struct key_entry dell_wmi_aio_keymap[] = {
> { KE_KEY, 0xc0, { KEY_VOLUMEUP } },
> { KE_KEY, 0xc1, { KEY_VOLUMEDOWN } },
> + { KE_KEY, 0xe030, { KEY_VOLUMEUP } },
> + { KE_KEY, 0xe02e, { KEY_VOLUMEDOWN } },
> + { KE_KEY, 0xe020, { KEY_MUTE } },
> + { KE_KEY, 0xe027, { KEY_DISPLAYTOGGLE } },
> + { KE_KEY, 0xe006, { KEY_BRIGHTNESSUP } },
> + { KE_KEY, 0xe005, { KEY_BRIGHTNESSDOWN } },
> + { KE_KEY, 0xe00b, { KEY_SWITCHVIDEOMODE } },
This is starting to look awfully like the keymap in dell-wmi.c. There's
probably an argument for merging them at the source level, even if it
ends up duplicated in both drivers.
> + if (dell_wmi_aio_event_check(obj->buffer.pointer,
> + obj->buffer.length)) {
Are we guaranteed that the old events will never look like this?
--
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
