Re: make i2c_adapter_names static to avoid sparse warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Actually, it looks like there's a checkpatch warning :

WARNING: static const char * array should probably be static const char * const
#20: FILE: drivers/platform/x86/chromeos_laptop.c:34:
+static const char *i2c_adapter_names[] = {

total: 0 errors, 1 warnings, 8 lines checked

On Tue, Jan 29, 2013 at 4:16 PM, Benson Leung <bleung@xxxxxxxxxxxx> wrote:
>  Reviewed-by: Benson Leung <bleung@xxxxxxxxxxxx>
>
> Thanks,
> Benson
>
> On Thu, Dec 27, 2012 at 12:07 AM, Xiechanglong <changlongx.xie@xxxxxxxxx> wrote:
>> Signed-off-by: Changlong Xie <changlongx.xie@xxxxxxxxx>
>> ---
>> Index: linux/drivers/platform/x86/chromeos_laptop.c
>> ===================================================================
>> --- linux.orig/drivers/platform/x86/chromeos_laptop.c
>> +++ linux/drivers/platform/x86/chromeos_laptop.c
>> @@ -31,7 +31,7 @@
>>  static struct i2c_client *als;
>>  static struct i2c_client *tp;
>>
>> -const char *i2c_adapter_names[] = {
>> +static const char *i2c_adapter_names[] = {
>>         "SMBus I801 adapter",
>>  };
>>
>
>
>
> --
> Benson Leung
> Software Engineer, Chrom* OS
> bleung@xxxxxxxxxxxx



-- 
Benson Leung
Software Engineer, Chrom* OS
bleung@xxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux