On Wed, 2012-12-19 at 06:39 +0900, Mattia Dongili wrote: > On Tue, Dec 18, 2012 at 03:08:44PM +0800, Zhang Rui wrote: > > Hi, Mattia, > > Hi Rui! > > > I generated a similar patch as yours but I still have one concern about the fix. > > thanks for taking care of that. > > > memcpy(buffer, (void *)&object->integer.value, len) may break the byte order but > > sony_nc_rfkill_setup() terminates if byte 0xff is checked. > > is this true? or am I thinking wrong? > > You're correct, sony_nc_rfkill_setup() stops looking at the buffer as > soon as it hits 0xff but why do you think memcpy would break the byte > order? > I'm not sure how SN06 works. say, you have supported codes 0x00, 0x10, and 0x20, what would SN06 return? 0x001020FF00000000 or 0x00000000FF201000? thanks, rui -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
