On Mon, Aug 13, 2012 at 08:59:41PM +0200, Bernhard Froemel wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 08/13/2012 08:17 PM, Seth Forshee wrote: > > It was discussed briefly on irc. > > > > http://irclogs.ubuntu.com/2012/08/09/%23ubuntu-kernel.txt > > > Yes, it's very similar. Don't want to start any wars here ;) but: > >>> but I think his implementation looked cleaner > I only occasionally write kernel code, but can't there be any > concurrency issues during reads/writes of internal gmux registers (I > used a semaphore to prevent that)? Especially if vga_switcheroo also > taps in? There aren't concurrency issues right now since only backlight is supported, and the backlight class driver serializes callbacks into the driver with a mutex. But when switcheroo support is added some concurrency protection is probably necessary. A mutex should be used rather than a semaphore however. Seth -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
