On Thu, May 03, 2012 at 04:02:18PM -0500, Seth Forshee wrote:
> On Thu, May 03, 2012 at 09:32:57PM +0100, Matthew Garrett wrote:
> > Merged for -next, thanks. I fixed up the conflicts with the the
> > transflective display patch, but someone should probably verify them.
>
> At a glance I see a couple of obvious mistakes, one of which will fail
> to build.
>
> > static int __get_lcd_brightness(struct toshiba_acpi_dev *dev)
> > {
> > u32 hci_result;
> > u32 value;
> > + int brightness;
>
> brightness needs to be initialized to 0. As-is it should generate a
> warning about using an uninitialized variable.
>
> > static const struct backlight_ops toshiba_backlight_data = {
> > + .iotns = BL_CORE_SUSPENDRESUME,
>
> Should be options.
Also:
+
+ /* Determine whether or not BIOS supports transflective backlight */
+ ret = get_tr_backlight_status(dev, &enabled);
+ dev->tr_backlight_supported = !ret;
The first line of this block has trailing white-space.
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
