Re: [PATCH] [thinkpad_acpi] Correctly inform userspace about max brightness.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Henrique,

any comment on this patch?

Best Regards
Jens

On Sat, Mar 24, 2012 at 04:04:57PM +0100, Jens Taprogge wrote:
> Since thinkpad_acpi (currently?) only supports switching the leds on or
> off, we should inform userspace about that.  Currently 256 brightness
> levels are reported by userspace.
> 
> Please apply.
> ---
>  drivers/platform/x86/thinkpad_acpi.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index a0bc79f..cb549d0 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -4827,6 +4827,7 @@ static enum led_brightness light_sysfs_get(struct led_classdev *led_cdev)
>  static struct tpacpi_led_classdev tpacpi_led_thinklight = {
>  	.led_classdev = {
>  		.name		= "tpacpi::thinklight",
> +		.max_brightness = 1,
>  		.brightness_set	= &light_sysfs_set,
>  		.brightness_get	= &light_sysfs_get,
>  	}
> @@ -5232,6 +5233,7 @@ static int __init tpacpi_init_led(unsigned int led)
>  	if (!tpacpi_led_names[led])
>  		return 0;
>  
> +	tpacpi_leds[led].led_classdev.max_brightness = 1;
>  	tpacpi_leds[led].led_classdev.brightness_set = &led_sysfs_set;
>  	tpacpi_leds[led].led_classdev.blink_set = &led_sysfs_blink_set;
>  	if (led_supported == TPACPI_LED_570)
> -- 
> 1.7.5.4
> 
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux