On Thu, Apr 05, 2012 at 11:36:48PM +0900, Akio Idehara wrote:
> >> static const struct backlight_ops toshiba_backlight_data = {
> >> + .options = BL_CORE_SUSPENDRESUME,
> >
> > What's the reason for adding this? I don't see that it's useful unless
> > we're handling BL_CORE_SUSPENDED, which toshiba_acpi is not doing.
>
>
> The reason is to restore transflective status, which is always disabled
> after resuming. If BL_CORE_SUSPENDRESUME is added,
> set_lcd_state_status() is called from backlight_update_status() with
> stored brightness. So, when its brightness is 0, transflective status is
> enabled after resuming.
Okay, that makes sense.
Since you're in the neighborhood, would you mind fixing the whitespace
issues in the other fields of toshiba_backlight_data while you're at it?
Both get_brightness and update_status are indented using spaces rather
than a tab.
Thanks,
Seth
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
