Re: [PATCH] topstar-latop: ignore 0x82 event

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 26, 2011 at 03:04:54PM +0200, Manuel Lauss wrote:
> Event 0x82 is emitted whenever a backlight event happens (brightness
> change, backlight on/off).  For instance, when display is switched
> off after a timeout, event 0x82 is emitted, and along with it a keypress
> which switches the display back on again.

Oh interesting side effect since 170531ba, really sparse_keymap_report_event
when not finding the key now generates a KEY_UNKNOWN press.

The fix is ok, I think the best approach is just ignoring it:

Acked-by: Herton R. Krzesinski <herton.krzesinski@xxxxxxxxxxxxx>

> 
> This patch adds 0x82 to the event ignore list so that the display stays
> off when it is automatically switched off.
> 
> Signed-off-by: Manuel Lauss <manuel.lauss@xxxxxxxxxxxxxx>
> ---
>  drivers/platform/x86/topstar-laptop.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/platform/x86/topstar-laptop.c b/drivers/platform/x86/topstar-laptop.c
> index 4c20447..d528daa 100644
> --- a/drivers/platform/x86/topstar-laptop.c
> +++ b/drivers/platform/x86/topstar-laptop.c
> @@ -41,6 +41,7 @@ static const struct key_entry topstar_keymap[] = {
>  	{ KE_KEY, 0x8c, { KEY_MEDIA } },
>  
>  	/* Known non hotkey events don't handled or that we don't care yet */
> +	{ KE_IGNORE, 0x82, }, /* backlight event */
>  	{ KE_IGNORE, 0x8e, },
>  	{ KE_IGNORE, 0x8f, },
>  	{ KE_IGNORE, 0x90, },
> -- 
> 1.7.6.1
> 

-- 
[]'s
Herton
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux